Skip to content

Compression OrderBy & SegmentBy#33

Merged
sebastian-ederer merged 5 commits intocmdscale:mainfrom
towner-10:compression-attributes
Feb 4, 2026
Merged

Compression OrderBy & SegmentBy#33
sebastian-ederer merged 5 commits intocmdscale:mainfrom
towner-10:compression-attributes

Conversation

@towner-10
Copy link
Contributor

@towner-10 towner-10 commented Jan 29, 2026

Introduces configuration to support the timescaledb.compress_segmentby and timescaledb.compress_orderby compression attributes. It is also able to pull the configuration from the database itself.

Solves #32

Usage / Example

builder.IsHypertable(x => x.Date)
            .WithChunkSkipping(x => x.Date)
            .WithChunkTimeInterval("1 day")
            .WithCompressionSegmentBy(x => x.TypeId)
            .WithCompressionOrderBy(x =>
            [
                x.ByDescending(m => m.Date)
            ]);

@sebastian-ederer
Copy link
Contributor

sebastian-ederer commented Jan 30, 2026

Thank you so much for the commit. ❤️
Currently, I am heavily involved in other projects, but I'll review the PR in the next few days! 👍

@sebastian-ederer
fix: improve OrderBy consistency and add XML documentation
8e32b8d 
Fix scaffolding round-trip mismatch by omitting default NULLS clauses to NULLS FIRST). Change OrderByExtensions default from bool to bool? with null default to prevent phantom migrations between API styles. Replace var with explicit types and triple-slash inline comments with double-slash per coding standards.
@sebastian-ederer sebastian-ederer self-requested a review February 4, 2026 15:49
@codecov
Copy link

codecov bot commented Feb 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.69421% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sign/Scaffolding/HypertableScaffoldingExtractor.cs 88.09% 2 Missing and 3 partials ⚠️
...c/Eftdb/Generators/HypertableOperationGenerator.cs 96.92% 0 Missing and 2 partials ⚠️
...s/Features/Hypertables/HypertableModelExtractor.cs 97.22% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@sebastian-ederer
Copy link
Contributor

sebastian-ederer commented Feb 4, 2026

FYI: The PR was very good. I've added some tests for the classes in OrderBy.cs to meet the criterias of codecove and did some minor refactorings regarding XML-Comments and using explicit types instead of var.

Thank you very much for your work! :)

@sebastian-ederer sebastian-ederer merged commit 679355c into cmdscale:main Feb 4, 2026
2 checks passed
@towner-10 towner-10 deleted the compression-attributes branch February 4, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastian-ederer sebastian-ederer sebastian-ederer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@towner-10 @sebastian-ederer